[
https://issues.apache.org/jira/browse/HDFS-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776560#comment-13776560
]
Chris Nauroth commented on HDFS-5191:
-------------------------------------
Great, thank you for incorporating the feedback.
bq. even if there is an overall test timeout, it's nicer to use
GenericTestUtils#waitFor.
Agreed, it helps narrow the problem down to a specific point in the test code.
Thanks for making that change.
libhdfs looks good too. Just a couple of minor things:
{code}
* You must free all options structures allocated with this function using
* readZeroOptionsFree.
{code}
Change readZeroOptionsFree to hadoopRzOptionsFree.
{code}
* This buffer will continue to be valid and readable
* until it is released by readZeroBufferFree. Failure to
{code}
Change readZeroBufferFree to hadoopRzBufferFree.
{code}
hadoopRzOptionsClearCached(env, opts);
opts->cachedEnumSet = NULL;
{code}
Setting {{cachedEnumSet}} to {{NULL}} isn't required here, because
{{hadoopRzOptionsClearCached}} already does it.
I'll be +1 for the whole patch after this. I'm also interested in getting the
zero-copy API and client-side mmap'ing changes merged to trunk and branch-2
(but not the additional datanode caching/mlock'ing that's in the HDFS-4949
branch). This will make it easier for clients like ORC to start coding against
the APIs. If necessary, I can volunteer to put together a merge patch with
just the zero-copy changes.
> revisit zero-copy API in FSDataInputStream to make it more intuitive
> --------------------------------------------------------------------
>
> Key: HDFS-5191
> URL: https://issues.apache.org/jira/browse/HDFS-5191
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, libhdfs
> Affects Versions: HDFS-4949
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5191-caching.001.patch,
> HDFS-5191-caching.003.patch, HDFS-5191-caching.006.patch,
> HDFS-5191-caching.007.patch, HDFS-5191-caching.008.patch,
> HDFS-5191-caching.009.patch
>
>
> As per the discussion on HDFS-4953, we should revisit the zero-copy API to
> make it more intuitive for new users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
