[ 
https://issues.apache.org/jira/browse/HDFS-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832005#comment-13832005
 ] 

Andrew Wang commented on HDFS-5556:
-----------------------------------

I missed this before, but are we sure we want to add new stats to 
NameNodeMXBean rather than FSNamesystemMBean? It's a public stable interface, 
so modifications here are not backwards compatible.

I'd also like to see a test a la TestNameNodeMetrics verifying that the new NN 
metrics show up. It should be straightfoward to insert a few more checks in an 
existing caching test or check method. We can wait on CachePoolStats tests 
until they're hooked up.

> add some more NameNode cache statistics, cache pool stats
> ---------------------------------------------------------
>
>                 Key: HDFS-5556
>                 URL: https://issues.apache.org/jira/browse/HDFS-5556
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5556.001.patch, HDFS-5556.002.patch
>
>
> Add some more NameNode cache statistics and also cache pool statistics.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to