[
https://issues.apache.org/jira/browse/HDFS-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835174#comment-13835174
]
Hadoop QA commented on HDFS-5581:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12616332/HDFS-5581.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestFsck
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5603//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5603//console
This message is automatically generated.
> NameNodeFsck should use only one instance of BlockPlacementPolicy
> -----------------------------------------------------------------
>
> Key: HDFS-5581
> URL: https://issues.apache.org/jira/browse/HDFS-5581
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Vinay
> Assignee: Vinay
> Attachments: HDFS-5581.patch
>
>
> While going through NameNodeFsck I found that following code creates the new
> instance of BlockPlacementPolicy for every block.
> {code} // verify block placement policy
> BlockPlacementStatus blockPlacementStatus =
> BlockPlacementPolicy.getInstance(conf, null, networktopology).
> verifyBlockPlacement(path, lBlk, targetFileReplication);{code}
> It would be better to use the namenode's BPP itself instead of creating a new
> one.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
