[
https://issues.apache.org/jira/browse/HDFS-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836653#comment-13836653
]
Colin Patrick McCabe commented on HDFS-5581:
--------------------------------------------
+1. thanks, Vinay.
> NameNodeFsck should use only one instance of BlockPlacementPolicy
> -----------------------------------------------------------------
>
> Key: HDFS-5581
> URL: https://issues.apache.org/jira/browse/HDFS-5581
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Vinay
> Assignee: Vinay
> Attachments: HDFS-5581.patch, HDFS-5581.patch
>
>
> While going through NameNodeFsck I found that following code creates the new
> instance of BlockPlacementPolicy for every block.
> {code} // verify block placement policy
> BlockPlacementStatus blockPlacementStatus =
> BlockPlacementPolicy.getInstance(conf, null, networktopology).
> verifyBlockPlacement(path, lBlk, targetFileReplication);{code}
> It would be better to use the namenode's BPP itself instead of creating a new
> one.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
