[
https://issues.apache.org/jira/browse/HDFS-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847869#comment-13847869
]
Andrew Wang commented on HDFS-5350:
-----------------------------------
Hey Jimmy, thanks for the patch. It looks pretty good, just a few review
comments:
* GetImageServlet is used to transfer both images and edits. Since these look
like they should be image-only metrics, we need to move the timing out of
serveFile (which is used for both) into the right if statement. I think this is
also more clear, since now all the timing will be in the same function.
* Could you add a new test to TestNameNodeMetrics showing that this gets
updated as expected?
> Name Node should report fsimage transfer time as a metric
> ---------------------------------------------------------
>
> Key: HDFS-5350
> URL: https://issues.apache.org/jira/browse/HDFS-5350
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Rob Weltman
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: trunk-5350.patch
>
>
> If the (Secondary) Name Node reported fsimage transfer times (perhaps the
> last ten of them), monitoring tools could detect slowdowns that might
> jeopardize cluster stability.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
