[ 
https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850907#comment-13850907
 ] 

Colin Patrick McCabe commented on HDFS-5574:
--------------------------------------------

actually, maybe I spoke too soon.  This patch removes a buffer copy from 
{{RemoteBlockReader2#skip}}, which HDFS-5634 doesn't change.  HDFS-5634 only 
affects {{BlockReaderLocal}}, not either of the remote block readers.  So 
Binglin, if you want to prepare a new version, it would be worth looking at.

> Remove buffer copy in BlockReader.skip
> --------------------------------------
>
>                 Key: HDFS-5574
>                 URL: https://issues.apache.org/jira/browse/HDFS-5574
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HDFS-5574.v1.patch, HDFS-5574.v2.patch
>
>
> BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read 
> data to this buffer, it is not necessary. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to