[
https://issues.apache.org/jira/browse/HDFS-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851189#comment-13851189
]
Andrew Wang commented on HDFS-5676:
-----------------------------------
Makes sense, good catch Colin. One comment and one question:
* Need to add caching strategy to method javadoc at DFSInputStream:1062
* Any reason you went with an AtomicReference swap for DFSOutputStream rather
than just using synchronized? I'd prefer synchronized if it's the same to you,
simpler and probably the same perf wise since this is unlikely to be contended.
+1 once addressed and pending Jenkins.
> fix inconsistent synchronization of CachingStrategy
> ---------------------------------------------------
>
> Key: HDFS-5676
> URL: https://issues.apache.org/jira/browse/HDFS-5676
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 2.4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-5676.001.patch
>
>
> Currently, the synchronization for {{CachingStrategy}} is a little
> inconsistent. DFSOutputStream#setDropBehind modifies the strategy object,
> but there's nothing protecting that object against concurrent use in
> {{createBlockOutputStream}}. Similarly, {{DFSInputStream#setDropBehind}} is
> synchronized, but not all the uses of {{cachingStrategy}} are.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
