[
https://issues.apache.org/jira/browse/HDFS-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851388#comment-13851388
]
Hadoop QA commented on HDFS-5676:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12619237/HDFS-5676.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5754//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5754//console
This message is automatically generated.
> fix inconsistent synchronization of CachingStrategy
> ---------------------------------------------------
>
> Key: HDFS-5676
> URL: https://issues.apache.org/jira/browse/HDFS-5676
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Affects Versions: 2.4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-5676.001.patch, HDFS-5676.002.patch
>
>
> Currently, the synchronization for {{CachingStrategy}} is a little
> inconsistent. DFSOutputStream#setDropBehind modifies the strategy object,
> but there's nothing protecting that object against concurrent use in
> {{createBlockOutputStream}}. Similarly, {{DFSInputStream#setDropBehind}} is
> synchronized, but not all the uses of {{cachingStrategy}} are.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
