[ 
https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852021#comment-13852021
 ] 

Chris Nauroth commented on HDFS-5673:
-------------------------------------

One more note.  From looking at this patch alone, it might not be obvious why I 
chose to wrap the logic in function objects.  The reason for this is that all 
of the ACL modification methods in {{FSNamesystem}} are going to have the same 
overall workflow: 1) acquire write lock, 2) get existing ACL from inode, 3) 
apply modification, 4) set new ACL on inode, 5) log edit, 6) release write 
lock.  I'm anticipating that the common workflow can go into a helper method, 
and each ACL modification method can just pass in a different 
{{AclTransformation}} functor.

> Implement logic for modification of ACLs.
> -----------------------------------------
>
>                 Key: HDFS-5673
>                 URL: https://issues.apache.org/jira/browse/HDFS-5673
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5673.1.patch
>
>
> This patch will include the core logic for modification of ACLs.  This 
> includes support for all user-facing APIs that modify ACLs.  This will cover 
> access ACLs, default ACLs, automatic mask calculations, automatic inference 
> of unprovided default ACL entries, and validation to prevent creation of an 
> invalid ACL.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to