[
https://issues.apache.org/jira/browse/HDFS-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859169#comment-13859169
]
Colin Patrick McCabe commented on HDFS-5695:
--------------------------------------------
Because the edit log generated by {{testStored}} was (usually) generated on a
different computer than the computer running the JUnit test, {{testStored}} can
and does catch problems that {{testGenerated}} does not. I have seen this
happen in the past. I agree that it is somewhat annoying that test-patch.sh
doesn't currently support binary diffs, which sometimes leads to this file not
getting updated when it should, but that seems like something to fix in
test-patch.sh, not by removing tests.
bq. For now I think it might be a good time to remove it. We can add a rigorous
test suite to test the compatibility of edit logs if it is needed.
If you can think of any test that would have the same coverage as testStored,
we could think about replacing testStored with that. I don't think we should
remove testStored until we have added test that could replace it.
> Clean up TestOfflineEditsViewer and OfflineEditsViewerHelper
> ------------------------------------------------------------
>
> Key: HDFS-5695
> URL: https://issues.apache.org/jira/browse/HDFS-5695
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5695.000.patch
>
>
> TestOfflineEditsViewer and OfflineEditsViewerHelper duplicate some of the
> functionality available in DFSTestUtil. The code can be simplified.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
