[
https://issues.apache.org/jira/browse/HDFS-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859688#comment-13859688
]
Colin Patrick McCabe commented on HDFS-5695:
--------------------------------------------
Let me give two examples of {{testStored}} catching errors that I made. One
time, a patch I created broke checksum calculation on the edits.
{{testGenerated}} passed, since the incorrect checksum was being generated
consistently (although not correctly), but {{testStored}} pinpointed the
problem. Another time, I made a change which accidentally made an optional
field required. Of course, {{testStored}} found this error since the old
{{editsStored}} file had been generated by someone without my erroneous patch.
{{testStored}} really is one of the last lines of defense against these kind of
problems. The real last line is people trying out the code prior to a release,
but I would prefer not to rely on that.
> Clean up TestOfflineEditsViewer and OfflineEditsViewerHelper
> ------------------------------------------------------------
>
> Key: HDFS-5695
> URL: https://issues.apache.org/jira/browse/HDFS-5695
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5695.000.patch
>
>
> TestOfflineEditsViewer and OfflineEditsViewerHelper duplicate some of the
> functionality available in DFSTestUtil. The code can be simplified.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
