[
https://issues.apache.org/jira/browse/HDFS-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862130#comment-13862130
]
Jing Zhao commented on HDFS-5717:
---------------------------------
Some early comments:
# The second set should be V2.
{code}
+ fsn.setGenerationStampV1(s.getGenstampV1());
+ fsn.setGenerationStampV1(s.getGenstampV2());
{code}
# Let's use Preconditions instead of assert.
{code}
+ public void load(File file) throws IOException {
+ assert impl == null;
{code}
# It will be better to also check the layout version in
FSImageFormatProtobuf#load.
> Save FSImage header in protobuf
> -------------------------------
>
> Key: HDFS-5717
> URL: https://issues.apache.org/jira/browse/HDFS-5717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5717.000.patch
>
>
> This jira introduces the basic framework to serialize and deserialize FSImage
> in protobuf, and it serializes some header information in the new protobuf
> format.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
