[
https://issues.apache.org/jira/browse/HDFS-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863864#comment-13863864
]
Fengdong Yu commented on HDFS-5717:
-----------------------------------
One minor comments:
<code>
+ FSImageFormat.LoaderDelegator loader = FSImageFormat.newLoader(conf,
target);
</code>
Don't call newLoader, which is not meaningful, you can rename to PBLoader or
ProtoBufLoader etc.
> Save FSImage header in protobuf
> -------------------------------
>
> Key: HDFS-5717
> URL: https://issues.apache.org/jira/browse/HDFS-5717
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5717.000.patch, HDFS-5717.001.patch,
> HDFS-5717.002.patch
>
>
> This jira introduces the basic framework to serialize and deserialize FSImage
> in protobuf, and it serializes some header information in the new protobuf
> format.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
