[ 
https://issues.apache.org/jira/browse/HDFS-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-5673:
--------------------------------

    Attachment: HDFS-5673.5.patch

Here is patch version 5 with the following changes:

# {{AclEntry}} no longer implements {{Comparable}}.  Instead, 
{{AclTransformation}} defines its own {{Comparator}}.
# {{AclTransformation#copyDefaultsIfNeeded}} has been recoded to use binary 
search on sorted sub-lists of the access entries and the default entries.

I could not find a way to incorporate the feedback on mask calculation or 
merging and still maintain correctness.  We cannot reliably remove duplicates, 
because after concatenating and sorting, we no longer know which one is correct 
to remove.  The ACL spec entry needs to override the existing entry, but we've 
lost that information.  We'd also end up losing relevant information for mask 
calculation as stated in my earlier comment.

> Implement logic for modification of ACLs.
> -----------------------------------------
>
>                 Key: HDFS-5673
>                 URL: https://issues.apache.org/jira/browse/HDFS-5673
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5673.1.patch, HDFS-5673.2.patch, HDFS-5673.3.patch, 
> HDFS-5673.4.patch, HDFS-5673.5.patch
>
>
> This patch will include the core logic for modification of ACLs.  This 
> includes support for all user-facing APIs that modify ACLs.  This will cover 
> access ACLs, default ACLs, automatic mask calculations, automatic inference 
> of unprovided default ACL entries, and validation to prevent creation of an 
> invalid ACL.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to