[
https://issues.apache.org/jira/browse/HDFS-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865017#comment-13865017
]
Junping Du commented on HDFS-5721:
----------------------------------
Thanks Ted for the patch! I think TestHASafeMode is unrelated as I saw this get
failed intermittent.
However, would you mind to fix other similar issues for using FSImage in this
JIRA? I did a quick search and found following issues:
NameNode.java line 818 fsImage is created and formated but not get closed if
any exceptions are thrown.
FSNameSystem.java line 603, fsImage is created and loaded to namesystem but not
get closed if anything wrong.
BootstrapStandby.java line 192. image is created and initialized but not get
closed if exceptions are thrown.
> sharedEditsImage in Namenode#initializeSharedEdits() should be closed before
> method returns
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-5721
> URL: https://issues.apache.org/jira/browse/HDFS-5721
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: hdfs-5721-v1.txt
>
>
> At line 901:
> {code}
> FSImage sharedEditsImage = new FSImage(conf,
> Lists.<URI>newArrayList(),
> sharedEditsDirs);
> {code}
> sharedEditsImage is not closed before the method returns.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
