[jira] [Commented] (HDFS-5721) sharedEditsImage in Namenode#initializeSharedEdits() should be closed before method returns

[Junping Du (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865142#comment-13865142
 ] 

Junping Du commented on HDFS-5721:
----------------------------------

Thanks Ted for the patch! 
v2 patch looks good overall and only issue is we should replace *System.out* 
below with using LOG.
{code}
+      System.out.println("Encountered exception during format: " + ioe);
{code}
+1 when this issues is addressed.

> sharedEditsImage in Namenode#initializeSharedEdits() should be closed before 
> method returns
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5721
>                 URL: https://issues.apache.org/jira/browse/HDFS-5721
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: hdfs-5721-v1.txt, hdfs-5721-v2.txt
>
>
> At line 901:
> {code}
>       FSImage sharedEditsImage = new FSImage(conf,
>           Lists.<URI>newArrayList(),
>           sharedEditsDirs);
> {code}
> sharedEditsImage is not closed before the method returns.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)