[ 
https://issues.apache.org/jira/browse/HDFS-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874024#comment-13874024
 ] 

Chris Nauroth commented on HDFS-5758:
-------------------------------------

Is there a benefit to that change (other than mimicking libacl)?  I suppose we 
could change {{getAclStatus}} like that, but it does mean that all potential 
clients (not just getfacl) must do both a {{getFileStatus}} and a 
{{getAclStatus}} to get a complete picture of permissions.

I wasn't sure how {{removeAcl}} relates to that comment.  {{removeAcl}} is 
changing because it needs to be able to restore the group permissions into 
{{FsPermission}} (overwriting the mask) as described above.  This is also true 
for {{removeAclEntries}}, which can reduce an extended ACL to a minimal ACL if 
the ACL spec removes all extended entries.  It was easiest to handle this 
consistently through {{AclTransformation}}.

> NameNode: complete implementation of inode modifications for ACLs.
> ------------------------------------------------------------------
>
>                 Key: HDFS-5758
>                 URL: https://issues.apache.org/jira/browse/HDFS-5758
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5758.1.patch, HDFS-5758.2.patch
>
>
> This patch will complete the remaining logic for the ACL get and set APIs, 
> including remaining work in {{FSNamesystem}}, {{FSDirectory}} and storage in 
> the inodes.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to