[
https://issues.apache.org/jira/browse/HDFS-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875183#comment-13875183
]
Haohui Mai commented on HDFS-5758:
----------------------------------
The v4 patch looks good. I believe that it is simpler. Some comments:
{code}
+public static List<AclEntry> readINodeAcl(INodeWithAdditionalFields inode,
+ int snapshotId, boolean includeBaseEntries)
{code}
I'm not sure why {{includeBaseEntries}} is needed. It seems the parameter is
contradicted with the description of the function (which is returning the
logical ACLs).
{code}
+ newPerm = new FsPermission(accessEntries.get(0).getPermission(),
+ accessEntries.get(accessEntries.size() - 2).getPermission(),
+ accessEntries.get(accessEntries.size() - 1).getPermission(),
+ perm.getStickyBit(), true);
{code}
It seems that there might be out of bound access here.
> NameNode: complete implementation of inode modifications for ACLs.
> ------------------------------------------------------------------
>
> Key: HDFS-5758
> URL: https://issues.apache.org/jira/browse/HDFS-5758
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-5758.1.patch, HDFS-5758.2.patch, HDFS-5758.3.patch,
> HDFS-5758.4.patch
>
>
> This patch will complete the remaining logic for the ACL get and set APIs,
> including remaining work in {{FSNamesystem}}, {{FSDirectory}} and storage in
> the inodes.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
