[
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876674#comment-13876674
]
Jing Zhao commented on HDFS-5709:
---------------------------------
Thanks Andrew! The new patch looks good to me, +1. The only suggestion is that
maybe we do not need the following preconditions check since we already check
every component in renameReservedComponentOnUpgrade
{code}
+ Preconditions.checkArgument(DFSUtil.isValidName(newPath),
+ "Renamed path " + newPath + " is not a valid"
+ + " name. Please verify the value of "
+ + DFSConfigKeys.DFS_NAMENODE_UPGRADE_RENAME_RESERVED_SNAPSHOT);
{code}
> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
> Key: HDFS-5709
> URL: https://issues.apache.org/jira/browse/HDFS-5709
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Labels: snapshots, upgrade
> Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer
> to a directory named ".snapshot". We should at least print a better error
> message (which I believe was the original intention in HDFS-4666), and [~atm]
> proposed automatically renaming these files and directories.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
