[
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876886#comment-13876886
]
Jing Zhao commented on HDFS-5709:
---------------------------------
bq. because it catches an additional class of errors (e.g. ".." is valid in
some paths, but not others)
In the current DFSUtil#isValideName, ".." is allowed only when the path starts
with "/.reserved/.inodes", and this is used by NFS to use an inode id to
indicate a file/directory. For a real inode's local name, ".." should still be
disallowed. (HDFS-5104 made this change)
Thus I think we should also add checking for ".." in isValidComponent, and then
we actually can cover all the cases and we can remove the isValidName check.
> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
> Key: HDFS-5709
> URL: https://issues.apache.org/jira/browse/HDFS-5709
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Labels: snapshots, upgrade
> Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch,
> hdfs-5709-4.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer
> to a directory named ".snapshot". We should at least print a better error
> message (which I believe was the original intention in HDFS-4666), and [~atm]
> proposed automatically renaming these files and directories.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
