[ 
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877790#comment-13877790
 ] 

Aaron T. Myers commented on HDFS-5709:
--------------------------------------

bq. Where is this being proposed? Why is downgrade required in any of the 
proposed solutions?

The alternative to automatically renaming files is to have to do this, but I 
see now that your point is just to more forcefully make users aware that a 
rename is taking place. I personally think this is overkill, but I don't feel 
super strongly about this.

bq. Doing the same thing in multiple ways seems unnecessary and confusing. I do 
not see any significant advantage to it. Perhaps I do not understand this 
solution.

It won't be confusing at all for anyone who doesn't want it, since they'll just 
never set the config setting at all. For those users who want the rename to be 
a bit configurable, however, it will be a significant convenience. This isn't 
really any different than making something configurable but also setting a 
reasonable default that most users will not change.

> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
>                 Key: HDFS-5709
>                 URL: https://issues.apache.org/jira/browse/HDFS-5709
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: snapshots, upgrade
>         Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch, 
> hdfs-5709-4.patch, hdfs-5709-5.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer 
> to a directory named ".snapshot". We should at least print a better error 
> message (which I believe was the original intention in HDFS-4666), and [~atm] 
> proposed automatically renaming these files and directories.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to