[
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889246#comment-13889246
]
Aaron T. Myers commented on HDFS-5709:
--------------------------------------
Latest patch looks pretty good to me. Three small comments:
# The additional docs are now wrong - they still mention the configuration
variable.
# I'd recommend factoring out the NN args processing code into some static
function that you could write some tests for.
# Perhaps I misunderstand Suresh's suggestion, but I was under the impression
that the default renamed name would include the _current_ layout version, not
the layout version that added the feature making the name reserved. I don't
feel super strongly about this, but it surprised me to see it this way.
+1 once these are addressed.
> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
> Key: HDFS-5709
> URL: https://issues.apache.org/jira/browse/HDFS-5709
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Labels: snapshots, upgrade
> Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch,
> hdfs-5709-4.patch, hdfs-5709-5.patch, hdfs-5709-6.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer
> to a directory named ".snapshot". We should at least print a better error
> message (which I believe was the original intention in HDFS-4666), and [~atm]
> proposed automatically renaming these files and directories.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
