[
https://issues.apache.org/jira/browse/HDFS-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884914#comment-13884914
]
Andrew Wang commented on HDFS-5746:
-----------------------------------
Few more test-related comments:
* Tests for {{DSW#remove}} would be good, even when the race is fixed properly.
If I'm right about the inf loop, a test would have caught it.
* TestSCSMS, testStartupShutdown seems like a strict subset of
testAllocateSlots functionality.
* How about some prodding of a closed SCSMS too? Would also be good to test a
couple of the other {{free()}} paths of SCSMS, since it can happen at close of
the last slot, the SCSMS, and in allocateNextSlot too.
> add ShortCircuitSharedMemorySegment
> -----------------------------------
>
> Key: HDFS-5746
> URL: https://issues.apache.org/jira/browse/HDFS-5746
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, hdfs-client
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HDFS-5746.001.patch, HDFS-5746.002.patch,
> HDFS-5746.003.patch, HDFS-5746.004.patch
>
>
> Add ShortCircuitSharedMemorySegment, which will be used to communicate
> information between the datanode and the client about whether a replica is
> mlocked.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
