[
https://issues.apache.org/jira/browse/HDFS-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884919#comment-13884919
]
Andrew Wang commented on HDFS-5746:
-----------------------------------
bq. It doesn't infinitely loop, because sendCallback always removes the fd from
toRemove.
I missed this, good point. The verify I wanted was a second look at the code,
no need for a test.
bq. I like the current terminology. "lockable" just sounds vague
Okay, I'm alright with "anchorable" for the flag. Can we change the name of the
refcount field and methods though? "anchor" and "unanchor" do not sound not
incremental operations to me, and the field being named "anchor" does not evoke
a count.
bq, <slot index>
Yea, I was wondering since I didn't see a field and accessor for the slot
index. I assume that'll be added at some point though.
> add ShortCircuitSharedMemorySegment
> -----------------------------------
>
> Key: HDFS-5746
> URL: https://issues.apache.org/jira/browse/HDFS-5746
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, hdfs-client
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HDFS-5746.001.patch, HDFS-5746.002.patch,
> HDFS-5746.003.patch, HDFS-5746.004.patch
>
>
> Add ShortCircuitSharedMemorySegment, which will be used to communicate
> information between the datanode and the client about whether a replica is
> mlocked.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
