[ 
https://issues.apache.org/jira/browse/HDFS-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-5932:
--------------------------------

    Attachment: HDFS-5932.3.patch

Thanks for the review, Haohui.  I'm attaching patch version 3.

bq. Can you just catch the {{RpcNoSuchMethodException}}?

To be able to catch it directly, {{DFSClient}} must do the unwrapping, so I've 
included that change.

bq. I also wonder whether it is possible to cache the fs object directly 
instead.

I considered this, but it would put the logic at risk of failing for 
{{FileSystem}} subclasses that have a misbehaving {{hashCode}} or {{equals}}.  
We don't define these in the base class, and I'm not aware of any requirement 
we've placed on custom implementations that they must override them.  URI on 
the other hand is already used in the {{FileSystem}} cache key, so we already 
have an implicit assumption in the code (for better or worse) that subclasses 
must return a reasonable URI.

> Ls should display the ACL bit
> -----------------------------
>
>                 Key: HDFS-5932
>                 URL: https://issues.apache.org/jira/browse/HDFS-5932
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode, security
>            Reporter: Haohui Mai
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5932.1.patch, HDFS-5932.2.patch, HDFS-5932.3.patch
>
>
> Based on the discussion of HDFS-5923, the ACL bit is no longer passed to the 
> client directly. Ls should call {{getAclStatus()}} instead since it needs to 
> display the ACL bit as a part of the permission.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to