[
https://issues.apache.org/jira/browse/HDFS-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-5932:
--------------------------------
Attachment: HDFS-5932.4.patch
I'm attaching patch version 4.
bq. It's a little bit weird to unwrap RpcNoSuchMethodException in DFSClient.
Thanks for bringing this up. I meant to discuss it earlier. I agree that it's
inconsistent to unwrap this in the client. Patch v4 goes back to unwrapping
inside ls.
bq. The unit test can be greatly simplified using mockito, but it can be
addressed in a separate jira.
The trouble here is that Mockito decorates instances, not classes. For the
shell, the {{FileSystem}} cache takes responsbility for creating the instance
internally via reflection. We don't have direct control of the instance it
gets, only the class definition specified via configuration. To test that the
shell executes successfully (exit code 0), it seems this is what we have to do.
I don't see a way to use Mockito, but if you have an idea, let me know.
> Ls should display the ACL bit
> -----------------------------
>
> Key: HDFS-5932
> URL: https://issues.apache.org/jira/browse/HDFS-5932
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode, security
> Reporter: Haohui Mai
> Assignee: Chris Nauroth
> Attachments: HDFS-5932.1.patch, HDFS-5932.2.patch, HDFS-5932.3.patch,
> HDFS-5932.4.patch
>
>
> Based on the discussion of HDFS-5923, the ACL bit is no longer passed to the
> client directly. Ls should call {{getAclStatus()}} instead since it needs to
> display the ACL bit as a part of the permission.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
