[ 
https://issues.apache.org/jira/browse/HDFS-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HDFS-5907:
--------------------------------

    Attachment: HDFS-5907.05.patch
                patch-v04-v04.diff

Thanks for reviewing this again Suresh.

I updated the patch with an E2E test case.

I am sorry for creating the extra review iterations. To make it easier I 
diff'ed the v4 and v5 patches and attached the output. The changes from the 
last revision are:
# Remove bad call to {{restoreBlockFilesFromTrash}} when {{trashRoot}} is 
non-existent.
# Log when trash is enabled/disabled.
# Log when files are moved to trash in lieu of deletion.
# New test case and minor fix to {{MiniDFSCluster}} for the test.

There are a few more unit tests we can add for thoroughness but we can do that 
later.

Thanks!

> Handle block deletion requests during rolling upgrades
> ------------------------------------------------------
>
>                 Key: HDFS-5907
>                 URL: https://issues.apache.org/jira/browse/HDFS-5907
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: HDFS-5535 (Rolling upgrades)
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-5907.01.patch, HDFS-5907.02.patch, 
> HDFS-5907.04.patch, HDFS-5907.05.patch, patch-v04-v04.diff
>
>
> DN changes when a rolling upgrade is in progress:
> # DataNode should handle block deletions by moving block files to 'trash'.
> # Block files should be restored to their original locations during a 
> rollback.
> # Purge trash when the rolling upgrade is finalized.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to