[ 
https://issues.apache.org/jira/browse/HDFS-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920049#comment-13920049
 ] 

Andrew Wang commented on HDFS-3405:
-----------------------------------

Thanks for all the hard work and testing Vinay. I'm definitely glad we caught 
the 2GB+ case! I think the test failure is HDFS-6054, and not caused by this 
patch.

Just a few nits, +1 pending these:

- "Uploades" -> "Uploads" still
- "upto" -> "up to"
- Need to put the new chunksize config key in hdfs-default.xml

> Checkpointing should use HTTP POST or PUT instead of GET-GET to send merged 
> fsimages
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-3405
>                 URL: https://issues.apache.org/jira/browse/HDFS-3405
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 1.0.0, 3.0.0, 2.0.5-alpha
>            Reporter: Aaron T. Myers
>            Assignee: Vinayakumar B
>         Attachments: HDFS-3405.patch, HDFS-3405.patch, HDFS-3405.patch, 
> HDFS-3405.patch, HDFS-3405.patch, HDFS-3405.patch, HDFS-3405.patch, 
> HDFS-3405.patch, HDFS-3405.patch, HDFS-3405.patch, HDFS-3405.patch, 
> HDFS-3405.patch, HDFS-3405.patch, HDFS-3405.patch, HDFS-3405.patch, 
> HDFS-3405.patch
>
>
> As Todd points out in [this 
> comment|https://issues.apache.org/jira/browse/HDFS-3404?focusedCommentId=13272986&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13272986],
>  the current scheme for a checkpointing daemon to upload a merged fsimage 
> file to an NN is to issue an HTTP get request to tell the target NN to issue 
> another GET request back to the checkpointing daemon to retrieve the merged 
> fsimage file. There's no fundamental reason the checkpointing daemon can't 
> just use an HTTP POST or PUT to send back the merged fsimage file, rather 
> than the double-GET scheme.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to