[ 
https://issues.apache.org/jira/browse/HDFS-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985296#comment-13985296
 ] 

Fengdong Yu commented on HDFS-6299:
-----------------------------------

sorry, my comments is later, 
{code}
+    int prefixIndex = name.indexOf(".");
+    if (prefixIndex == -1) {
+      throw new HadoopIllegalArgumentException("XAttr name must be prefixed 
with" +
+          " user/trusted/security/system which followed by '.'");
+    } else if (prefixIndex == name.length() -1) {
+      throw new HadoopIllegalArgumentException("XAttr name can not be empty.");
+    }
{code}

It should be 
{code}
if (prefixIndex <= 0) {
{code}

other wise, the code will do waste before catch this Exception.

> Protobuf for XAttr and client-side implementation 
> --------------------------------------------------
>
>                 Key: HDFS-6299
>                 URL: https://issues.apache.org/jira/browse/HDFS-6299
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Uma Maheswara Rao G
>            Assignee: Yi Liu
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: HDFS-6299.patch
>
>
> This JIRA tracks Protobuf for XAttr and implementation for XAttr interfaces 
> in DistributedFilesystem and DFSClient. 
> With this JIRA we may just keep the dummy  implemenation for Xattr API of 
> ClientProtocol in NameNodeRpcServer



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to