[
https://issues.apache.org/jira/browse/HDFS-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985349#comment-13985349
]
Uma Maheswara Rao G commented on HDFS-6299:
-------------------------------------------
{quote}
2.
ClientRPC interface is not symmetrical, there are getXAttr(), getXAttrs(),
setXAttr(), so there should be setXAttrs().
3.
why there is no getXAttr() in the ClientProtocol? we should allow to get only
one xattr in one time.
{quote}
Please look at the client protocol interface audience. That is internal rpc
mechanism API. There is no guideline to have symmetrical api signatures with
client exposed API. See the create api in ClientProtocol, we will have only
one. but we exposed many overloaded APIs. Please look at the review comments in
HDFS-6258.
>please refer to other client methods in DFSClent, such as append() ?
Please also look at FileSystem#append doc. Both says same information, no
additional info there. So, from the exposed API doc, same and we just delegate
till this core implementation.
I am saying you again. You can file a new JIRA with your comments when they are
valid. This is a branch development. I don't see any critical issues from your
comments. I am not against adding some developper doc in DFSClient and at the
same time I am not insisting to have there.
Ex: see
setAcl,
removeAcl...
public DFSInputStream open(String src)
throws IOException, UnresolvedLinkException {
return open(src, dfsClientConf.ioBufferSize, true, null);
}
> Protobuf for XAttr and client-side implementation
> --------------------------------------------------
>
> Key: HDFS-6299
> URL: https://issues.apache.org/jira/browse/HDFS-6299
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Uma Maheswara Rao G
> Assignee: Yi Liu
> Fix For: HDFS XAttrs (HDFS-2006)
>
> Attachments: HDFS-6299.patch
>
>
> This JIRA tracks Protobuf for XAttr and implementation for XAttr interfaces
> in DistributedFilesystem and DFSClient.
> With this JIRA we may just keep the dummy implemenation for Xattr API of
> ClientProtocol in NameNodeRpcServer
--
This message was sent by Atlassian JIRA
(v6.2#6252)
