[
https://issues.apache.org/jira/browse/HDFS-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985864#comment-13985864
]
Charles Lamb commented on HDFS-6258:
------------------------------------
A few minor nits.
In XAttrPermissionFilter.java, please change the javadoc to read:
+/**
+ * There are 4 types for extended attribute <XAttr>:
There are four types of extended attributes <XAttr> defined by the
following namespaces:
USER -- extended user attributes: these can be assigned to files and
directories to store arbitrary additional information. The access
permissions for user attributes are defined by the file permission
bits.
TRUSTED -- trusted extended attributes: these are visible/accessible
only to/by the super user.
SECURITY -- extended security attributes: these are used by the HDFS
core for security purposes and are not available through admin/user
API.
SYSTEM -- extended system attributes: these are used by the HDFS
core and are not available through admin/user API.
Formatting nit, there's an extra newline right before the last } closing the
class.
XAttrStorage.java:
+ * XAttrStorage is used to read and set xattrs for inode.
s/for/on an/
> Namenode server-side storage for XAttrs
> ---------------------------------------
>
> Key: HDFS-6258
> URL: https://issues.apache.org/jira/browse/HDFS-6258
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-6258.1.patch, HDFS-6258.2.patch, HDFS-6258.3.patch,
> HDFS-6258.4.patch, HDFS-6258.patch
>
>
> Namenode Server-side storage for XAttrs: FSNamesystem and friends.
> Refine XAttrConfigFlag and AclConfigFlag to ConfigFlag.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
