[
https://issues.apache.org/jira/browse/HDFS-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986519#comment-13986519
]
Yi Liu commented on HDFS-6258:
------------------------------
Thanks Charles and Uma for the review.
{quote}
{code}
public static final String DFS_NAMENODE_XATTRS_MAX_LIMIT_KEY =
"dfs.namenode.xattrs.max-limit";
public static final int DFS_NAMENODE_XATTRS_MAX_LIMIT_DEFAULT = 32;
{code}
Do we need to mention per Inode max limit?
{quote}
Right, let's change it to {{dfs.namenode.inode.xattrs.max-limit}}
{quote}
Tests:
I think we need test cases for verifying inmemory xattrs updations and getting
them back. Which is kind of integrations test from client side to XattrFeature
usage.
{quote}
Good point, let's add a test case for all XAttr APIs to this patch for
verifying xattrs updating/retrieving in NN's memory.
{quote}
ConfigFlag.java:
How about having NNConf like DNConf which will load the config on statup and
have the check methods there?
{quote}
Right, let's rename it to NNConf.java, then it will be a common place for NN
configuration.
{quote}
....
You don't need empty line here.
...
Please remove tab characters above.
{quote}
OK, I will revise them.
{quote}
FSNamesystem.java:
{code}
try {
XAttrPermissionFilter.checkPermissionForApi(pc, xAttr);
} catch (AccessControlException e) {
logAuditEvent(false, "setXAttr", src);
}
checkOperation(OperationCategory.WRITE);
{code}
We need to rethrow exception from here right insted of continueing?
..
same as above comment.
{quote}
Right, {{throw e;}} was missing.
{quote}
Here checkPathAccess also throws AccessControlException, so we are not
considering it for failure audit log?
{quote}
OK, I will add failure audit log for it.
> Namenode server-side storage for XAttrs
> ---------------------------------------
>
> Key: HDFS-6258
> URL: https://issues.apache.org/jira/browse/HDFS-6258
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HDFS-6258.1.patch, HDFS-6258.2.patch, HDFS-6258.3.patch,
> HDFS-6258.4.patch, HDFS-6258.patch
>
>
> Namenode Server-side storage for XAttrs: FSNamesystem and friends.
> Refine XAttrConfigFlag and AclConfigFlag to ConfigFlag.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
