[
https://issues.apache.org/jira/browse/HDFS-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995997#comment-13995997
]
Uma Maheswara Rao G commented on HDFS-6377:
-------------------------------------------
Thanks a lot, Andrew for filing this JIRA and for the patch.
Adding to Liu's and Chris comments, I have following comments:
- . {code}
"XAttr is too big, maximum size = " + nnConf.xattrMaxSize
+ + ", but the size is = " + xAttr.getName().length());
{code}
Seems like now max size is combination of name and value size together, but
here you considered on name#length?
- . {code}
public static void init() throws Exception {
+ conf = new Configuration();
{code}
Lets use HdfsCOnfiguration? [ but no harm in using either :-) ]
- . {code}
fs.setXAttr(path, name1, longValue);
+ fs.setXAttr(path, "user.a", longValue);
{code}
you can use name1 for it?
-
Do you think we need to have minimum configuration limit? Lets say user
configured size as 3, then this is always invalid size as Namespace itself
occupy this space? [ I am not insisting, just to discuss this point ]
Atleast we can warn on startup saying, you can not add xattrs with configured
limit? [ I think 7 is the minimum size for adding xattr with user name space
where name and value can have one char each at least]
-
Thanks for the other cleanup.
Yes, I agree with Chris, having fs-limits for consistency make sense to me.
> Unify xattr name and value limits into a single limit
> -----------------------------------------------------
>
> Key: HDFS-6377
> URL: https://issues.apache.org/jira/browse/HDFS-6377
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-6377-1.patch
>
>
> Instead of having separate limits and config options for the size of an
> xattr's name and value, let's use a single limit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
