[
https://issues.apache.org/jira/browse/HDFS-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996982#comment-13996982
]
Chris Nauroth commented on HDFS-6377:
-------------------------------------
The patch looked good, Andrew. Thanks! Maybe a few potential cleanups:
{code}
+import java.io.UnsupportedEncodingException;
{code}
Is the import unused now?
{code}
- cacheManager.stopMonitorThread();
- cacheManager.clearDirectiveStats();
+ if (cacheManager != null) {
+ cacheManager.stopMonitorThread();
+ cacheManager.clearDirectiveStats();
+ }
{code}
Was this an unrelated change?
> Unify xattr name and value limits into a single limit
> -----------------------------------------------------
>
> Key: HDFS-6377
> URL: https://issues.apache.org/jira/browse/HDFS-6377
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: HDFS XAttrs (HDFS-2006)
>
> Attachments: hdfs-6377-1.patch, hdfs-6377-2.patch
>
>
> Instead of having separate limits and config options for the size of an
> xattr's name and value, let's use a single limit.
--
This message was sent by Atlassian JIRA
(v6.2#6252)