[ 
https://issues.apache.org/jira/browse/HDFS-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997154#comment-13997154
 ] 

Charles Lamb commented on HDFS-6283:
------------------------------------

Nice. I have (as usual) a few minor nits below which are really optional. LGTM, 
+1.

"abbreviated as xattrs"

We should be careful that we are consistent throughout. I think I have seen it 
abbreviated as XAttrs in some places (like the code). Either way is fine with 
me, but we should be uniform.

"see the Linux manpage for attr(5) as well as the rest of the documentation)."

see the Linux attr manpage and related documentation).

"Xattrs must also specify a namespace => xattr names must also have a namespace 
prefix."

"These commands are styled after the Linux commands getfattr(1) and 
setfattr(1)" -> These commands are styled after the Linux getfattr(1) and 
setfattr(1) commands.



> Write end user documentation for xattrs.
> ----------------------------------------
>
>                 Key: HDFS-6283
>                 URL: https://issues.apache.org/jira/browse/HDFS-6283
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Chris Nauroth
>            Assignee: Andrew Wang
>         Attachments: hdfs-6283-1.patch, hdfs-6283-2.patch
>
>
> Update the File System Shell documentation to cover the new getfattr and 
> setfattr commands.  If warranted, consider adding a separate dedicated page 
> for fuller discussion of the xattrs model and how the feature works in more 
> detail.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to