[
https://issues.apache.org/jira/browse/HDFS-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000935#comment-14000935
]
Hadoop QA commented on HDFS-6424:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645394/HDFS-6424.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6927//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6927//console
This message is automatically generated.
> blockReport doesn't need to invalidate blocks on SBN
> ----------------------------------------------------
>
> Key: HDFS-6424
> URL: https://issues.apache.org/jira/browse/HDFS-6424
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: HDFS-6424.patch
>
>
> After the fix in https://issues.apache.org/jira/browse/HDFS-6178,
> blockManager no longer compute pending replication work on SBN. As part of
> that, it also stop removing items from invalidateBlocks.
> blocks can still be added to invalidateBlocks on SBN as part of blockReport.
> As a result, the PendingDeletionBlocks metrics will keep going up on SBN.
> To fix that, we don't need to add blocks to invalidateBlocks during
> blockReport for SBN.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
