[ 
https://issues.apache.org/jira/browse/HDFS-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016353#comment-14016353
 ] 

Vinayakumar B commented on HDFS-6465:
-------------------------------------

Hi [~dian.fu], 

This patch looks good.
I have found following comments too,

1. In MirrorUtil.java there are many util methods which are not used in this 
patch. It would be better for reviewer to validate, if its included in the same 
patch wherever its used.

2. According to design, we can start cluster in following modes based on 
configurations.
    a. *sync mode*,  This can be just *journal* sync mode or both *journal and 
data* sync mode. In this case, "journal" sync is mandatory, "data" sync is 
file/directory controlled.
    b. *async mode*, This is *everything* async mode. 

For enabling these modes, a configuration will be required. Are you planning to 
add this configuration in upcoming Jiras?


> Enable the configuration of multiple clusters
> ---------------------------------------------
>
>                 Key: HDFS-6465
>                 URL: https://issues.apache.org/jira/browse/HDFS-6465
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>         Attachments: HDFS-6465.1.patch, HDFS-6465.patch
>
>
> Tracks the changes required for configuration DR.
> configurations added:
>     DFS_REGION_ID("dfs.region.id") : the region id of current cluster
>     DFS_REGIONS("dfs.regions") : the region ids of all clusters, including 
> both the primary cluster and mirror cluster
>     DFS_REGION_PRIMARY("dfs.region.primary") : the region id of primary 
> cluster
> configurations modified:
>     The configurations in NAMENODE.NAMENODE_SPECIFIC_KEYS can be configured 
> in the following format to distinguish between clusters.
>     If a configuration with a region id as suffix cannot be found, the 
> configuration without region id as suffix will be used instead:
>     <configuration key>.<nameservice id>.<namenode id>.<region id>
> The configurations in NAMENODE.NAMESERVICE_SPECIFIC_KEYS can be configured in 
> the following format to distinguish between clusters.
> If a configuration with a region id as suffix cannot be found, the 
> configuration without region id as suffix will be used instead:
> <configuration key>.<nameservice id>.<region id>



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to