[ 
https://issues.apache.org/jira/browse/HDFS-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017301#comment-14017301
 ] 

Dian Fu commented on HDFS-6465:
-------------------------------

Hi Vinay,

Thanks very much for your review of the patch. 
{quote}In MirrorUtil.java there are many util methods which are not used in 
this patch. It would be better for reviewer to validate, if its included in the 
same patch wherever its used.{quote}
Yes, agree with you that including these util methods in the patch where they 
are used would be better. But as these methods are just some util methods, I 
think it's OK to include these methods here too.
{quote}For enabling these modes, a configuration will be required. Are you 
planning to add this configuration in upcoming Jiras?{quote}
Yes, of course. will add configurations to separate sync mode from async mode 
in the upcoming jiras.Thanks again for the review.


> Enable the configuration of multiple clusters
> ---------------------------------------------
>
>                 Key: HDFS-6465
>                 URL: https://issues.apache.org/jira/browse/HDFS-6465
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>         Attachments: HDFS-6465.1.patch, HDFS-6465.patch
>
>
> Tracks the changes required for configuration DR.
> configurations added:
>     DFS_REGION_ID("dfs.region.id") : the region id of current cluster
>     DFS_REGIONS("dfs.regions") : the region ids of all clusters, including 
> both the primary cluster and mirror cluster
>     DFS_REGION_PRIMARY("dfs.region.primary") : the region id of primary 
> cluster
> configurations modified:
>     The configurations in NAMENODE.NAMENODE_SPECIFIC_KEYS can be configured 
> in the following format to distinguish between clusters.
>     If a configuration with a region id as suffix cannot be found, the 
> configuration without region id as suffix will be used instead:
>     <configuration key>.<nameservice id>.<namenode id>.<region id>
> The configurations in NAMENODE.NAMESERVICE_SPECIFIC_KEYS can be configured in 
> the following format to distinguish between clusters.
> If a configuration with a region id as suffix cannot be found, the 
> configuration without region id as suffix will be used instead:
> <configuration key>.<nameservice id>.<region id>



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to