[
https://issues.apache.org/jira/browse/HDFS-6403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033365#comment-14033365
]
Aaron T. Myers commented on HDFS-6403:
--------------------------------------
Hey Yongjun, the latest patch looks pretty good to me, but I'm a little uneasy
about moving the JvmPauseMonitor into the JvmMetrics class. Even though I think
that will work, it seems like inappropriate encapsulation to me. The JvmMetrics
class should really just be setting up metrics, gauges, etc. and storing a
handful of counters. Seems inappropriate to me to have the JvmMetrics class now
also be creating a thread and doing its own monitoring of the process.
Would you be alright with changing this patch around to instead keep the
instantiation of the JvmPauseMonitor like it was, and just pass in a reference
to that to the JvmMetrics class? Should be pretty straightforward, and I think
would keep the object hierarchy a bit more sane.
> Add metrics for log warnings reported by JVM pauses
> ---------------------------------------------------
>
> Key: HDFS-6403
> URL: https://issues.apache.org/jira/browse/HDFS-6403
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, namenode
> Affects Versions: 2.4.0
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Attachments: HDFS-6403.001.patch, HDFS-6403.002.patch
>
>
> HADOOP-9618 logs warnings when there are long GC pauses. If this is exposed
> as a metric, then they can be monitored.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
