[ 
https://issues.apache.org/jira/browse/HDFS-6403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038010#comment-14038010
 ] 

Aaron T. Myers commented on HDFS-6403:
--------------------------------------

Hi Yongjun, the latest patch looks pretty good to me. Thanks a lot for 
incorporation my feedback.

One small comment: I think that the new method {{JvmMetrics#getPauseMonitor}} 
is currently unused. Mind removing that?

+1 once this is addressed.

> Add metrics for log warnings reported by JVM pauses
> ---------------------------------------------------
>
>                 Key: HDFS-6403
>                 URL: https://issues.apache.org/jira/browse/HDFS-6403
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode, namenode
>    Affects Versions: 2.4.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-6403.001.patch, HDFS-6403.002.patch, 
> HDFS-6403.003.patch, HDFS-6403.004.patch
>
>
> HADOOP-9618 logs warnings when there are long GC pauses. If this is exposed 
> as a metric, then they can be monitored.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to