[
https://issues.apache.org/jira/browse/HDFS-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050676#comment-14050676
]
Colin Patrick McCabe commented on HDFS-6482:
--------------------------------------------
I agree with the reasoning about the two-level directory structure.
I see that your code adds a binary .tgz file:
{code}
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-24-datanode-dir.tgz
b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-24-datanode-dir.tgz
new file mode 100644
index
0000000000000000000000000000000000000000..49c9b15875e9d4c51a6fd06448ef54c2ced5e863
GIT binary patch
literal 320695
zcmYgXc{tSV_kQ10Ldcfvm94C$h7c0jcQeK=lw~BLA$!?n3)%O577W?4XAjwDC~L?z
zvKu?|`-tA(_dl-dbe{9v_kHejKF=kN&`bY7Vd=X6ko+Dc)z^g*N!R>uTshB~@%H+8
zde$pSkDGL?E?s#h+$#I5>&l0zrouuGoc0o|a6|$P2cscI_BcbYLXU08Qc(?V2-WKI
{code}
Unfortunately, our patch apply script doesn't understand git binary diffs :(
So the tgz is not getting picked up, and leading to this spurious test failure.
{code}
org.apache.hadoop.util.Shell$ExitCodeException: gzip:
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/target/test-classes/hadoop-24-datanode-dir.tgz:
No such file or directory
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
{code}
{code}
- // nothing to do here
+ // nothing to do hereFile dir =
{code}
Looks like a typo.
+1 once this is addressed.
> Use block ID-based block layout on datanodes
> --------------------------------------------
>
> Key: HDFS-6482
> URL: https://issues.apache.org/jira/browse/HDFS-6482
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: James Thomas
> Assignee: James Thomas
> Attachments: HDFS-6482.1.patch, HDFS-6482.2.patch, HDFS-6482.3.patch,
> HDFS-6482.4.patch, HDFS-6482.5.patch, HDFS-6482.6.patch, HDFS-6482.patch
>
>
> Right now blocks are placed into directories that are split into many
> subdirectories when capacity is reached. Instead we can use a block's ID to
> determine the path it should go in. This eliminates the need for the LDir
> data structure that facilitates the splitting of directories when they reach
> capacity as well as fields in ReplicaInfo that keep track of a replica's
> location.
> An extension of the work in HDFS-3290.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
