[ 
https://issues.apache.org/jira/browse/HDFS-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063210#comment-14063210
 ] 

Vinayakumar B commented on HDFS-6671:
-------------------------------------

patch looks better.
One small suggestion, It would be better if we differentiate the 
{{chooseTarget}} overloaded methods in BlockManager by name itself, instead of 
specifying the usage in comments. 
ex: chooseAdditionalDatanodeTarget(..) and chooseWebHdfsTarget(..)
If you feel, current one is fine, then I am Ok with it.

+1, once this is addressed (if required).

> Archival Storage: Consider block storage policy in replicaiton
> --------------------------------------------------------------
>
>                 Key: HDFS-6671
>                 URL: https://issues.apache.org/jira/browse/HDFS-6671
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h6671_20140714.patch, h6671_20140715.patch, 
> h6671_20140715b.patch, h6671_20140715c.patch
>
>
> In order to satisfy storage policy requirement, replication monitor in 
> addition reads storage policy information from INodeFile when performing 
> replication.  As before, it only adds replicas if a block is under 
> replicated, and deletes replicas if a block is over replicated.  It will NOT 
> move replicas around for satisfying storage policy requirement.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to