[ https://issues.apache.org/jira/browse/HDFS-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071377#comment-14071377 ]
Vinayakumar B commented on HDFS-6686: ------------------------------------- I have 2 doubts 1. In the below code, for the retry, whether {{oldExcludedNodes}} should be passed or {{excludedNodes}} should be passed..? since {{avoidStaleNodes}} is passed as false.? By default, {{avoidStaleNodes}} is false, hence {{oldExcludedNodes}} will be null, so I feel, original {{excludedNodes}} will be missed and it can choose already excluded node again.. no? {code} if (storageTypes.size() > 0) { // Retry chooseTarget with fallback storage types unavailableStorages.add(curStorageType); return chooseTarget(numOfReplicas, writer, oldExcludedNodes, blocksize, maxNodesPerRack, results, false, storagePolicy, unavailableStorages); }{code} 2. For the PipelineRecovery (getAdditionalDatanode()) calls also, it uses replicationFallback storageType, whether this is Ok? > Archival Storage: Use fallback storage types > -------------------------------------------- > > Key: HDFS-6686 > URL: https://issues.apache.org/jira/browse/HDFS-6686 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Attachments: h6686_20140721.patch, h6686_20140721c.patch > > > HDFS-6671 changes replication monitor to use block storage policy for > replication. It should also use the fallback storage types when a particular > type of storage is full. -- This message was sent by Atlassian JIRA (v6.2#6252)