[ 
https://issues.apache.org/jira/browse/HDFS-6686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071394#comment-14071394
 ] 

Arpit Agarwal commented on HDFS-6686:
-------------------------------------

Hi Nicholas, took a look at the patch. Also have two questions:
# The recursive call on line 393 passes the same results list so the callee 
might choose the replication fallback instead of creation fallback.
# Perhaps I misunderstood - on line 318, should we update numOfResults instead 
of numOfReplicas? Later we check numOfResults before dequeuing entries from 
storageTypes.



> Archival Storage: Use fallback storage types
> --------------------------------------------
>
>                 Key: HDFS-6686
>                 URL: https://issues.apache.org/jira/browse/HDFS-6686
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h6686_20140721.patch, h6686_20140721c.patch
>
>
> HDFS-6671 changes replication monitor to use block storage policy for 
> replication.  It should also use the fallback storage types when a particular 
> type of storage is full.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to