[
https://issues.apache.org/jira/browse/HDFS-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113245#comment-14113245
]
Hadoop QA commented on HDFS-6958:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12664785/HDFS-6958.000.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7799//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7799//console
This message is automatically generated.
> Fix the condition of reporting failures in BlockPoolSlice
> ---------------------------------------------------------
>
> Key: HDFS-6958
> URL: https://issues.apache.org/jira/browse/HDFS-6958
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Trivial
> Attachments: HDFS-6958.000.patch
>
>
> {{BlockPoolSlice#addToReplicsMap()}} should log the failure for the operation
> that deletes restart metadata file.
> The current code did the opposite, log the failures on succeed deletion:
> {code:java}
> if (restartMeta.delete()) {
> FsDatasetImpl.LOG.warn("Failed to delete restart meta file: " +
> restartMeta.getPath());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
