[
https://issues.apache.org/jira/browse/HDFS-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115794#comment-14115794
]
Aaron T. Myers commented on HDFS-6958:
--------------------------------------
+1, patch looks good to me. It's fairly obviously trivially correct, so I don't
think there's any need for a test on this one.
I'm going to commit this momentarily.
> Fix the condition of reporting failures in BlockPoolSlice
> ---------------------------------------------------------
>
> Key: HDFS-6958
> URL: https://issues.apache.org/jira/browse/HDFS-6958
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Trivial
> Attachments: HDFS-6958.000.patch
>
>
> {{BlockPoolSlice#addToReplicsMap()}} should log the failure for the operation
> that deletes restart metadata file.
> The current code did the opposite, log the failures on succeed deletion:
> {code:java}
> if (restartMeta.delete()) {
> FsDatasetImpl.LOG.warn("Failed to delete restart meta file: " +
> restartMeta.getPath());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
