[ https://issues.apache.org/jira/browse/HDFS-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115846#comment-14115846 ]
Andrew Wang commented on HDFS-6843: ----------------------------------- Hi Steve W, I do not want to raise the bar to code contributions. I'm grateful that people manage to find time to file a JIRA and post a patch in the first place. Requiring another couple hours and patch revs might be the difference between getting something committed vs. having the person get discouraged and disappear. I see this happen all the time as it is. Let me also step through why I think follow-ons are good: * It's easy for interested parties to track. The JIRA summary will almost certainly say "update filesystem contact", and we could also have a JIRA label like "fscontract" or "hcfs" which people can watch. * The follow-on JIRA will focus solely on the contract, so it should be easier to review. * I don't know if your average committer is able to properly review spec changes anyway. Most of us do not maintain a HCFS, so do not necessarily have the same understanding of the concerns as someone who does. Getting a rubberstamp +1 to the spec change isn't that meaningful. I'd appreciate if we could take any further discussion to common-dev / hdfs-dev, as this JIRA is not the right forum. > Create FSDataInputStream & FSDataOutputStream isEncrypted() method > ------------------------------------------------------------------ > > Key: HDFS-6843 > URL: https://issues.apache.org/jira/browse/HDFS-6843 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode, security > Affects Versions: 3.0.0 > Reporter: Charles Lamb > Assignee: Charles Lamb > Attachments: HDFS-6843.001.patch, HDFS-6843.002.patch, > HDFS-6843.003.patch > > > FileStatus should have a 'boolean isEncrypted()' method. (it was in the > context of discussing with AndreW about FileStatus being a Writable). > Having this method would allow MR JobSubmitter do the following: > ----- > BOOLEAN intermediateEncryption = false > IF jobconf.contains("mr.intermidate.encryption") THEN > intermediateEncryption = jobConf.getBoolean("mr.intermidate.encryption") > ELSE > IF (I/O)Format INSTANCEOF File(I/O)Format THEN > intermediateEncryption = ANY File(I/O)Format HAS a Path with status > isEncrypted()==TRUE > FI > jobConf.setBoolean("mr.intermidate.encryption", intermediateEncryption) > FI -- This message was sent by Atlassian JIRA (v6.2#6252)