[ 
https://issues.apache.org/jira/browse/HDFS-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139331#comment-14139331
 ] 

Colin Patrick McCabe commented on HDFS-6970:
--------------------------------------------

This is a nice simplification.  

In 
{code}
     // Flip-flop between two EZs to repeatedly fail
-    for (int i=0; i<10; i++) {
+    for (int i=0; i<11; i++) {
       injector.ready.await();
{code}

Can you put this 10 as a constant in DFSOutputStream, VisibleForTesting?

+1 once that's addressed

> Move startFile EDEK retries to the DFSClient
> --------------------------------------------
>
>                 Key: HDFS-6970
>                 URL: https://issues.apache.org/jira/browse/HDFS-6970
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption
>    Affects Versions: 2.5.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-6970.001.patch
>
>
> [~sureshms] pointed out that holding on to an RPC handler while talking to 
> the KMS is bad, since it can exhaust the available handlers. Let's avoid this 
> by doing retries at the DFSClient rather than in the RPC handler, and moving 
> EDEK fetching to the background.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to