[
https://issues.apache.org/jira/browse/HDFS-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhe Zhang updated HDFS-6987:
----------------------------
Attachment: HDFS-6987-20140919-v1.patch
[~andrew.wang] Thanks a lot for the thorough review! I double checked and I
think this new patch addresses the comments. A few things:
* I checked every place that CipherSuite appears in method signatures and made
sure it's in a consistent order with other types as in {{FileEncryptionInfo}}.
Let me know if you see anything that's still missing.
* I still don't fully understand why {{getMetadata}} doesn't involve an
additional RPC. It will talk to the key provider right?
* I changed {{createEncryptionZone}} to just get the metadata from the provider
by the {{keyName}} and verify it's non-null ({{KeyProvider.Metadata metadata =
provider.getMetadata(keyName);}}), rather than trying to get the {{keyVersion}}
by {{getCurrentKey}}. Let me know if that looks correct.
> Move CipherSuite xattr information up to the encryption zone root
> -----------------------------------------------------------------
>
> Key: HDFS-6987
> URL: https://issues.apache.org/jira/browse/HDFS-6987
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption
> Reporter: Andrew Wang
> Assignee: Zhe Zhang
> Attachments: HDFS-6987-20140917-v1.patch,
> HDFS-6987-20140918-v1.patch, HDFS-6987-20140919-v1.patch
>
>
> All files within a single EZ need to be encrypted with the same CipherSuite.
> Because of this, I think we can store the CipherSuite once in the EZ rather
> than on each file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
