[ 
https://issues.apache.org/jira/browse/HDFS-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148319#comment-14148319
 ] 

Hadoop QA commented on HDFS-7131:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12671299/HDFS-7131.001.patch
  against trunk revision 9f9a222.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.
        {color:red}-1 core tests{color}.  Failed to build the native portion of 
hadoop-common prior to running the unit tests in   
hadoop-hdfs-project/hadoop-hdfs

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8209//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8209//artifact/PreCommit-HADOOP-Build-patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8209//console

This message is automatically generated.

> During HA upgrade, JournalNode should create a new committedTxnId file in the 
> current directory
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7131
>                 URL: https://issues.apache.org/jira/browse/HDFS-7131
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: qjm
>    Affects Versions: 2.4.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-7131.000.patch, HDFS-7131.001.patch
>
>
> Currently while doing HA upgrade, we do not create a new committedTxnId file  
>   in the new current directory of JournalNode. And before we have the fix in 
> HDFS-7042, since the file channel is never closed, for any new journal we're 
> actually updating the committedTxnId file in the previous directory. This can 
> cause NN to fail to start while rollback.
> HDFS-7042 fixes the main part of the issue: the file channel inside of the 
> committedTxnId object gets closed thus later a new file can be created in the 
> current directory. But maybe it is still better to copy the content file 
> during the upgrade so that we can always use it for sanity check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to